Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No log entries to stderr when in production - VPN-2207 #3504

Merged
merged 1 commit into from
May 11, 2022
Merged

Conversation

bakulf
Copy link
Collaborator

@bakulf bakulf commented May 11, 2022

No description provided.

@bakulf bakulf requested a review from strseb May 11, 2022 12:44
@codecov-commenter
Copy link

Codecov Report

Merging #3504 (935ea62) into main (a137512) will decrease coverage by 47.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #3504       +/-   ##
==========================================
- Coverage   54.65%   7.64%   -47.01%     
==========================================
  Files         291      62      -229     
  Lines       17361    2211    -15150     
  Branches     5772    1166     -4606     
==========================================
- Hits         9488     169     -9319     
+ Misses       7158    1875     -5283     
+ Partials      715     167      -548     
Flag Coverage Δ
functional_tests ?
lottie_tests ?
qml_tests 7.64% <0.00%> (-3.49%) ⬇️
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/loghandler.cpp 15.02% <0.00%> (-62.09%) ⬇️
src/hkdf.h 0.00% <0.00%> (-100.00%) ⬇️
src/task.h 0.00% <0.00%> (-100.00%) ⬇️
src/hkdf.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/models/server.h 0.00% <0.00%> (-100.00%) ⬇️
lottie/lib/lottieprivatedocument.h 0.00% <0.00%> (-100.00%) ⬇️
lottie/lib/lottieprivatedocument.cpp 0.00% <0.00%> (-95.24%) ⬇️
src/update/versionapi.cpp 5.10% <0.00%> (-92.25%) ⬇️
lottie/lib/lottieprivatewindow.h 0.00% <0.00%> (-89.48%) ⬇️
src/hawkauth.cpp 0.00% <0.00%> (-88.58%) ⬇️
... and 277 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a137512...935ea62. Read the comment docs.

@bakulf bakulf merged commit 17466b5 into main May 11, 2022
@bakulf bakulf deleted the noLogInProd branch May 11, 2022 13:48
aaronkollasch pushed a commit to aaronkollasch/mozilla-vpn-client that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants